Demote process output to Debug severity #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is perhaps a more controversial change. The process output is quite noisy, and arguably not of interest unless you're debugging an issue. The counterargument is that if something *does* go wrong with running the cradle command, it's useful to see it. Perhaps we could collect the output and only emit it on failure?
|
IIRC, aren't these logs used for displaying progress messages in VSCode? (Maybe I am mistaken) |
|
Uh. I have no idea. That would be... surprising. |
|
Hm, maybe not. Maybe we should add a different Constructor in this case? Such as |
|
Okay, I checked. As far as I can tell, at the moment these go via
Yeah, good idea. |
|
Added a special constructor for it. |
fendor
approved these changes
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is perhaps a more controversial change. The process output is quite
noisy, and arguably not of interest unless you're debugging an issue.
The counterargument is that if something does go wrong with running the
cradle command, it's useful to see it. Perhaps we could collect the
output and only emit it on failure?