Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with aeson 1.5 #368

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Compatibility with aeson 1.5 #368

merged 2 commits into from
Sep 13, 2022

Conversation

wz1000
Copy link
Contributor

@wz1000 wz1000 commented Sep 12, 2022

Incompatible with #367

Should apply #367 to a branch and do the hackage revision

@hasufell
Copy link
Member

hie-bios is not used by anyone else than HLS? I think supporting ancient dependency versions is not very important

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, I would like to have some automatic way of checking that it builds with a certain version...

@fendor
Copy link
Collaborator

fendor commented Sep 13, 2022

hie-bios is not used by anyone else than HLS? I think supporting ancient dependency versions is not very important

Issue is that not all HLS versions build with aeson-2.

@hasufell
Copy link
Member

hie-bios is not used by anyone else than HLS? I think supporting ancient dependency versions is not very important

Issue is that not all HLS versions build with aeson-2.

What's the problem with locking those into an old hie-bios?

Or did you mean GHC versions?

@fendor
Copy link
Collaborator

fendor commented Sep 13, 2022

I meant ghc versions, yes.

@fendor fendor merged commit 58cbd64 into master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants