Add more informative log messages for cradle running #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
force-pushed
the
enhance/more-loggers
branch
from
04df167
to
22ce865
Compare
michaelpj
approved these changes
Jun 11, 2023
| ShellCommand sh -> pretty sh | ||
| RawCommand cmd args -> pretty cmd <+> pretty (unwords args) | ||
| ] | ||
| <> |
There was a problem hiding this comment.
Suggested change
| <> | |
| line |
There was a problem hiding this comment.
That adds an extra new line in the case where we have no environment variables.
There was a problem hiding this comment.
You can do vcat [doc1, doc2] if you like. Just that this one will try to lay it out on one line, which you probably don't want
| -- ------------------------------------------------ | ||
|
|
||
| -- | Prettify 'CmdSpec', so we can show the command to a user | ||
| prettyCmdSpec :: CmdSpec -> String |
There was a problem hiding this comment.
These aren't returning Doc because they're being used by other stuff, right?
fendor
force-pushed
the
enhance/more-loggers
branch
from
22ce865
to
9e0c490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just addig more logging information, including environment variable information.