Add searchable cradle dependencies #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends hie.yaml file format with the "dependencies" object. Extends Bios cradle type with an optional FilePath to obtain cradle dependencies. Set for each cradle type the cradle dependencies. Reorganise parsing of "hie.yaml".
fendor
commented
Sep 16, 2019
| cradleRootDir = wdir | ||
| , cradleOptsProg = CradleAction "obelisk" (obeliskAction wdir) | ||
| obeliskCradleDependencies :: FilePath -> IO [FilePath] | ||
| obeliskCradleDependencies _wdir = return [] |
There was a problem hiding this comment.
Couldnt find any obelisk files in a very shallow search (mainly the obelisk gh page)
fendor
changed the title
|
I think just needs a update to the |
fendor
force-pushed
the
better-cradle-deps
branch
2 times, most recently
from
cb1a46a
to
a2a7766
Compare
fendor
force-pushed
the
better-cradle-deps
branch
from
a2a7766
to
58de5c1
Compare
mpickering
reviewed
Sep 17, 2019
|
Surely the |
My reasoning was these are the depedencies of a cradle and a cradle specification consists of a type of cradle and dependencies to that cradle. |
|
Can you change the Then I will merge it. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends hie.yaml file format with the "dependencies" object.
Extends Bios cradle type with an optional FilePath to
obtain cradle dependencies from.
Set for each cradle type the cradle dependencies.
Reorganise parsing of "hie.yaml".
hie.yamla bit more, smoke testing succeededNote: parsing of hie.yaml is less strict now, if there is a field such as "dependecies" (note missing 'n'), it will parse, assuming the correct field "dependencies" is not defined.
Closes #35
Makes #39 obsolete