Add Loading Style option to 'runAction' #433
Conversation
fendor
force-pushed
the
enhance/loading-style
branch
from
10afd5b
to
412f81b
Compare
There was a problem hiding this comment.
Possibly stupid question, but would it make more sense to just consider this a different cradle type? It's not clear that it really is an orthogonal setting, e.g. it makes no sense if you set it and you have a stack or direct cradle. Or maybe you should get an error in that case? But a separate cradle type might work nicely. Then in HLS/hie-bios we can give people a choice of direct/stack/cabal/cabal-multi.
|
Also, if we did my suggestion about making this a cradle type, then exposing that in HLS would naturally fix haskell/haskell-language-server#3832 |
fendor
force-pushed
the
enhance/loading-style
branch
2 times, most recently
from
6859fb1
to
9d51a5a
Compare
src/HIE/Bios/Types.hs
Outdated
| pretty (LogRequestedCradleLoadStyle crdlName ls) = | ||
| "Request loading" <+> pretty crdlName <+> "cradle using" <+> case ls of | ||
| SingleComponent -> "Single Component Strategy" | ||
| LoadWithContext fps -> "Multiple Components Strategy:" <> line <> indent 4 (pretty fps) |
There was a problem hiding this comment.
The terminology seems a bit inconsistent now. Is it single-component vs multi-component, or single-component vs "with context"?
There was a problem hiding this comment.
It seems like from the hie-bios perspective the truth is that it's either one file or many files, right? hie-bios doesn't particularly judge whether or not they're in different components or anything. Just that you can ask for flags to load one file, or a bunch of files.
There was a problem hiding this comment.
Yeah, that is true. But logs are still kind of user facing, so I thought, it might be better to use the terminology we would use in HLS.
Should we uniformly use the hie-bios perspective here?
There was a problem hiding this comment.
I think it makes hie-bios more confusing if we're not consistent. But maybe we're just a bit confused about what hie-bios is saying it will do? Or perhaps we can make the message informative enough to cover both: "Requested to load cradle using all open files (multi-component)" or something?
There was a problem hiding this comment.
that's a good suggestion, updated!
There was a problem hiding this comment.
I also renamed the LoadStyle constructors to reflect this more accurately.
fendor
force-pushed
the
enhance/loading-style
branch
3 times, most recently
from
71b2e17
to
56e19ef
Compare
Allows users to decide at run-time whether they would like to use experimental features, such as `cabal`'s `multi-repl` feature that will be released in 3.12. The `LoadStyle` can not always be honoured by the respective cradle. For example, if the ghc version or cabal version isn't recent enough.
fendor
force-pushed
the
enhance/loading-style
branch
from
56e19ef
to
4180002
Compare
No description provided.