Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port stack cradle to windows reusing cabal one #50

Merged
merged 2 commits into from
Sep 19, 2019

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 19, 2019

D:\ws\haskell\stack-test>hie-bios check src\Lib.hs
cradle
  Cradle {cradleRootDir = "D:\\ws\\haskell\\stack-test", cradleOptsProg = Cradle
Action: stack}
[1 of 1] Compiling Main             ( C:\TEMP\wra9706.hs, C:\TEMP\wra9706.o )
Linking C:\TEMP\wra9727.exe ...
setTargets
  (src\Lib.hs , src\Lib.hs)
  [*src\Lib.hs]
modGraph
  [ModSummary {
      ms_hs_date = 2019-09-19 10:48:00.2052186 UTC
      ms_mod = Lib,
      ms_textual_imps = [(Nothing, Prelude), (Nothing, Data.Bifunctor)]
      ms_srcimps = []
   }]
modGraph
  [ModLocation {ml_hs_file = Just "src\\Lib.hs", ml_hi_file = "C:\\Users\\user\\A
ppData\\Local\\haskell-ide-engine\\3b7875f2994913e87022150ffb4d1f15c9fcf26f\\Lib
.hi", ml_obj_file = "D:\\ws\\haskell\\stack-test\\.stack-work\\odir\\Lib.o"}]
hidir
  Just [C, :, \, U, s, e, r, s, \, u, s, e, r, \, A, p, p, D, a, t, a,
        \, L, o, c, a, l, \, h, a, s, k, e, l, l, -, i, d, e, -, e, n, g,
        i, n, e, \, 3, b, 7, 8, 7, 5, f, 2, 9, 9, 4, 9, 1, 3, e, 8, 7, 0,
        2, 2, 1, 5, 0, f, f, b, 4, d, 1, f, 1, 5, c, 9, f, c, f, 2, 6, f]
src\Lib.hs:16:5:Warning: Defined but not used: data constructor ‘Const’
src\Lib.hs:17:5:Warning: Defined but not used: data constructor ‘X’
src\Lib.hs:18:5:Warning: Defined but not used: data constructor ‘Cos’
.......
src\Lib.hs:76:1:Warning: Defined but not used: ‘simplify’

@jneira jneira changed the title Port stack cradle to win reusing cabal one Port stack cradle to windows reusing cabal one Sep 19, 2019
@@ -229,6 +229,7 @@ getCabalWrapperTool = do
return wrapper_fp
else do
writeSystemTempFile "bios-wrapper" cabalWrapper
-- TODO: This isn't portable for windows
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is portable, because the definition comes from unix-compat, at least it works correctly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it does so it could be deleted (i kept the existing comment without too much thinking)

@mpickering
Copy link
Collaborator

Yes, good point.

@mpickering mpickering merged commit 3313dfc into haskell:master Sep 19, 2019
@jneira jneira deleted the win-stack-cradle branch September 19, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hie-bios does not work with stack on Windows 10
2 participants