Implement logging with optional hslogger dependency #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
commented
Oct 4, 2019
|
Why make hslogger optional? It's not a huge dependency, and certainly making it mandatory isn't going to upset clients like ghcide. |
|
@ndmitchell if the additional dependencies are alright, including network and network-bsd, we can add it as a required dependency. opinion, @mpickering ? |
|
We already have |
mpickering
pushed a commit
that referenced
this pull request
Oct 12, 2019
* Implement logging with hslogger
mpickering
pushed a commit
that referenced
this pull request
Oct 14, 2019
* Implement logging with hslogger
mpickering
pushed a commit
that referenced
this pull request
Oct 14, 2019
* Implement logging with hslogger
mpickering
pushed a commit
that referenced
this pull request
Oct 14, 2019
* Implement logging with hslogger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.