Correctly parse the output from the bios executable #80
Conversation
Multi-word arguments must be parsed correctly. E.g., currently `-flag 'foo bar'` is parsed as [-flag, 'foo, bar']. It should be [-flag, 'foo bar']. Use the shellwords package for that.
hie-bios.cabal
Outdated
| @@ -53,6 +53,7 @@ Library | |||
| process >= 1.6.1 && < 1.7, | |||
| file-embed >= 0.0.10 && < 0.1, | |||
| ghc >= 8.2.2 && < 8.9, | |||
| shellwords >= 0.1.2 && < 0.2, | |||
There was a problem hiding this comment.
This adds a megaparsec dependency which I want to avoid.
There was a problem hiding this comment.
Now this PR expects arguments to be newline-delimited. Each argument must be in its own line.
So the only change now is words res -> lines res.
This will break existing users.
|
The solution in the cabal case was to delimit the arguments by |
I can do that. But wouldn't it break existing users? Or I can write my own parsing logic here, but I guess that'll require some kind of parser combinator package anyway to make it simple. If you're fine with breaking existing users, I can go with the |
|
What about using a newline as the delimiter? I assume that's easier for custom bios programs to generate outputs. will become |
This removes the shellwords package dependency. Previously the arguments were space-delimited but now they are newline-delimited. So each argument must be in its own lines. This is a breaking change.
|
Using newlines seems like quite an ingenious solution. In bash is there a convenient way to convert a list of arguments separated by spaces to one separated by newlines? I am just wondering how to convert the GHCi target in the ghc repo to work if the repl arguments target returns newline rather than space separated arguments. The documentation also needs updating but a lot of it is out of date anyway. |
|
Made a slight change in the README.md file. Re: converting spaces to newlines, maybe |
|
I think it will be easier to convert newlines into spaces, so I'll go that direction. |
Multi-word arguments must be parsed correctly. E.g., currently
-flag 'foo bar'is parsed as [-flag, 'foo, bar'].It should be [-flag, 'foo bar'].
Use the shellwords package for that.