API tidy up, comments, remove unused code etc #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
reviewed
Nov 14, 2019
| @@ -27,17 +27,16 @@ Library | |||
| HIE.Bios.Config | |||
| HIE.Bios.Cradle | |||
| HIE.Bios.Environment | |||
| HIE.Bios.Debug | |||
| HIE.Bios.Internal.Debug | |||
There was a problem hiding this comment.
Listed modules were sorted. If it doesnt matter, not a blocker, just sayin'
fendor
reviewed
Nov 14, 2019
| b <- readIORef ref | ||
| writeIORef ref id | ||
| return $! convert opt (b []) | ||
| return $! unlines (b []) |
There was a problem hiding this comment.
Out of interest, I think this is one of the very few places where ($!) is used. Is there a reason for it?
There was a problem hiding this comment.
This is old code from hpp still so I can't comment on the reason.
fendor
approved these changes
Nov 14, 2019
|
Haddock Documentation is a bit broken. We can fix that in a follow-up PR, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.