Fix and extend Haddock documentation #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpickering
reviewed
Nov 14, 2019
| @@ -57,10 +57,10 @@ withGhcT body = do | |||
|
|
|||
| ---------------------------------------------------------------- | |||
|
|
|||
| -- | Initialise a GHC session by loading a given file into a given cradle. | |||
| -- | Initialize a GHC session by loading a given file into a given cradle. | |||
There was a problem hiding this comment.
Hehe, I actually wanted to ask: Are we using GB or US english here? Function names are US but most comments are GB
mpickering
reviewed
Nov 14, 2019
src/HIE/Bios/Types.hs
Outdated
| | CradleNone -- ^ No attempt was made to load the cradle | ||
| -- | Result of an attempt to set up a GHC session for a 'Cradle'. | ||
| -- This is the go-to error handling mechanism. When possible, this | ||
| -- should be preferd over throwing exceptions. |
There was a problem hiding this comment.
Suggested change
| -- should be preferd over throwing exceptions. | |
| -- should be preferred over throwing exceptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.