Add cradle tests #91

mpickering · 2019-11-15T22:50:41Z

Other changes

Pass --no-nix-pure to stack, otherwise it runs the nix-shell with
--pure which unsets all env vars.
Expose CradleError from HIE.Bios module
Return the success flag from the initialisation action.

mpickering · 2019-11-15T22:50:58Z

What's the best way to setup CI for windows? @jneira ?

jneira · 2019-11-16T08:39:57Z

Mmm if travis is already being used i would use it for win too, like lsp-test: https://github.com/bubba/lsp-test/blob/master/.travis.yml

jneira · 2019-11-16T10:03:13Z

In the meanwhile i've run the tests locally:

PS D:\dev\ws\haskell\hie-bios> cabal test
Resolving dependencies...
Build profile: -w ghc-8.6.5 -O1
In order, the following will be built (use -v for more details):
 - hie-bios-0.3.0 (lib) (configuration changed)
 - hie-bios-0.3.0 (test:parser-tests) (configuration changed)
 - hie-bios-0.3.0 (test:bios-tests) (first run)
Configuring library for hie-bios-0.3.0..
Preprocessing library for hie-bios-0.3.0..
Building library for hie-bios-0.3.0..
[11 of 16] Compiling HIE.Bios.Ghc.Api ( src\HIE\Bios\Ghc\Api.hs, D:\dev\ws\haskell\hie-bios\dist-newstyle\build\x86_64-windows\ghc-8.6.5\hie-bios-0.3.0\build\HIE\Bios\Ghc\Api.o )
[14 of 16] Compiling HIE.Bios.Ghc.Check ( src\HIE\Bios\Ghc\Check.hs, D:\dev\ws\haskell\hie-bios\dist-newstyle\build\x86_64-windows\ghc-8.6.5\hie-bios-0.3.0\build\HIE\Bios\Ghc\Check.o )
[15 of 16] Compiling HIE.Bios.Cradle  ( src\HIE\Bios\Cradle.hs, D:\dev\ws\haskell\hie-bios\dist-newstyle\build\x86_64-windows\ghc-8.6.5\hie-bios-0.3.0\build\HIE\Bios\Cradle.o )
[16 of 16] Compiling HIE.Bios         ( src\HIE\Bios.hs, D:\dev\ws\haskell\hie-bios\dist-newstyle\build\x86_64-windows\ghc-8.6.5\hie-bios-0.3.0\build\HIE\Bios.o )
Configuring test suite 'parser-tests' for hie-bios-0.3.0..
Configuring test suite 'bios-tests' for hie-bios-0.3.0..
Preprocessing test suite 'parser-tests' for hie-bios-0.3.0..
Building test suite 'parser-tests' for hie-bios-0.3.0..
Preprocessing test suite 'bios-tests' for hie-bios-0.3.0..
Building test suite 'bios-tests' for hie-bios-0.3.0..
[1 of 1] Compiling Main             ( tests\BiosTests.hs, D:\dev\ws\haskell\hie-bios\dist-newstyle\build\x86_64-windows\ghc-8.6.5\hie-bios-0.3.0\t\bios-tests\build\bios-tests\bios-tests-tmp\Main.o )
Linking D:\dev\ws\haskell\hie-bios\dist-newstyle\build\x86_64-windows\ghc-8.6.5\hie-bios-0.3.0\t\parser-tests\build\parser-tests\parser-tests.exe ...
Linking D:\dev\ws\haskell\hie-bios\dist-newstyle\build\x86_64-windows\ghc-8.6.5\hie-bios-0.3.0\t\bios-tests\build\bios-tests\bios-tests.exe ...
Running 1 test suites...
Test suite parser-tests: RUNNING...
Test suite parser-tests: PASS
Test suite logged to:
D:\dev\ws\haskell\hie-bios\dist-newstyle\build\x86_64-windows\ghc-8.6.5\hie-bios-0.3.0\t\parser-tests\test\hie-bios-0.3.0-parser-tests.log
1 of 1 test suites (1 of 1 test cases) passed.
Running 1 test suites...
Test suite bios-tests: RUNNING...
Loading tests
  simple-cabal:  OK (12.20s)
    Finding Cradle
    Loading Cradle
    Initialise Flags    (11.56s)
    Initial module load (0.57s)
    (1,2)               (0.05s)
    (2,2)               (0.02s)
  simple-stack:  FAIL (2.83s)
    Finding Cradle
    Loading Cradle
    Initialise Flags    (2.82s)
    Initial module load
      bios-tests.exe: can't find a package database at D:\bin\stack\x86_64-windows\ghc-8.6.5\lib\package.conf.d        
  simple-direct: OK (0.22s)
    Finding Cradle
    Loading Cradle
    Initialise Flags    (0.10s)
    Initial module load (0.03s)
    (1,2)               (0.07s)
    (2,2)               (0.02s)
  simple-bios:   FAIL (0.15s)
    Finding Cradle
    Loading Cradle
      D:\dev\ws\haskell\hie-bios\tests\projects\simple-bios\hie-bios: streamingProcess: invalid argument (Exec format error)

2 out of 4 tests failed (15.39s)
Test suite bios-tests: FAIL
Test suite logged to:
D:\dev\ws\haskell\hie-bios\dist-newstyle\build\x86_64-windows\ghc-8.6.5\hie-bios-0.3.0\t\bios-tests\test\hie-bios-0.3.0-bios-tests.log
0 of 1 test suites (0 of 1 test cases) passed.
cabal.exe: Tests failed for test:bios-tests from hie-bios-0.3.0.

It is catching the same error that #90 (comment) so the test suite works 👍

jneira · 2019-11-16T10:09:07Z

I am trying to add windows support to travis, taking as reference lsp-test. It would be great update haskell-ci to take in account the new travis feature (~~maybe it already supports it?~~ there is a open issue to add win support: haskell-CI/haskell-ci#199)

fendor · 2019-11-16T14:17:15Z

hie-bios.cabal

@@ -1,21 +1,27 @@
+Cabal-Version:          2.4


I might be wrong, but doesnt this force us to build this package with cabal 2.4 at least?
This will break old stack lts snapshots, since they got shipped with older cabal versions. Iirc, it would force hie to drop stack support for GHC versions older than 8.6.
At least lower the Cabal-Version to 2.2. What was the problem with 1.1?

You need Cabal-2.4 for tests/projects/**/*.hs syntax.

src/HIE/Bios/Ghc/Api.hs

fendor · 2019-11-16T14:32:15Z

tests/projects/simple-stack/CHANGELOG.md

+# Revision history for simple-cabal
+
+## 0.1.0.0 -- YYYY-mm-dd
+
+* First version. Released on an unsuspecting world.


This is probably noise and could be removed from the .cabal file and the repo

fendor · 2019-11-16T14:34:10Z

tests/projects/package-stack/stack.yaml

@@ -0,0 +1,66 @@
+# This file was automatically generated by 'stack init'


this seems like a lonely stack.yaml does it not have any friends, e.g. source files?

fendor · 2019-11-16T14:35:35Z

src/HIE/Bios/Cradle.hs

@@ -373,7 +373,7 @@ stackAction work_dir l fp = do
  -- Same wrapper works as with cabal
  wrapper_fp <- getCabalWrapperTool
  (ex1, _stdo, stde, args) <-
-      readProcessWithExitCodeInDirectory l work_dir "stack" ["repl", "--no-load", "--with-ghc", wrapper_fp, fp ]
+      readProcessWithExitCodeInDirectory l work_dir "stack" ["repl", "--no-nix-pure", "--no-load", "--with-ghc", wrapper_fp, fp ]


--no-nix-pure has no impact when nix is not enabled right?
Maybe add a comment that it does not?

fendor · 2019-11-16T14:36:19Z

src/HIE/Bios.hs

@@ -11,6 +11,7 @@ module HIE.Bios (
  -- * Find and load a Cradle
    Cradle(..)
  , CradleLoadResult(..)
+  , CradleError(..)


I guess this fixes the build error in #90?

fendor · 2019-11-16T14:36:53Z

If I want to add tests, should I open a PR to your PR or push directly to this branch?

mpickering · 2019-11-16T14:37:39Z

@fendor You can push directly to this branch. I'll make sure not to force push.

Now all the cradles communicate by reading the value of HIE_BIOS_OUTPUT which is a filepath, and writing the arguments to that temporary file. This makes all the cradles more robust about the build tools spurting things to stdout.

Other changes * Pass `--no-nix-pure` to stack, otherwise it runs the nix-shell with `--pure` which unsets all env vars. * Expose `CradleError` from `HIE.Bios` module * Return the success flag from the initialisation action.

mpickering mentioned this pull request Nov 15, 2019

Make major release #88

Closed

14 tasks

mpickering force-pushed the wip/no-stdout branch from 6084098 to 17c48ed Compare November 16, 2019 10:38

mpickering force-pushed the wip/tests branch from 380cd74 to b9d3a1f Compare November 16, 2019 10:38

fendor requested changes Nov 16, 2019

View reviewed changes

mpickering and others added 12 commits November 18, 2019 22:47

Don't use stdout to communicate arguments

201bb3d

Now all the cradles communicate by reading the value of HIE_BIOS_OUTPUT which is a filepath, and writing the arguments to that temporary file. This makes all the cradles more robust about the build tools spurting things to stdout.

Add cradle tests

6d52e54

Other changes * Pass `--no-nix-pure` to stack, otherwise it runs the nix-shell with `--pure` which unsets all env vars. * Expose `CradleError` from `HIE.Bios` module * Return the success flag from the initialisation action.

Try to fix travis

749b134

Fix sdist rules

cb0452f

More fix

12bcf1e

Fix cabal file

69dbfb8

Add missing file

c459e4c

Add multi-component tests

33aafdd

Remove ghc environment files

71eadcf

Make FilePath to load relative to cradle root

606957e

Remove tracing output

a86df2a

Fix test-project .cabal files

42b1499

fendor force-pushed the wip/tests branch from 1fd4c15 to 42b1499 Compare November 18, 2019 21:49

mpickering changed the base branch from wip/no-stdout to master November 18, 2019 22:02

mpickering added 3 commits November 18, 2019 23:18

Export Success flag

4207f9b

Also test setTargetFiles

b13de70

Remove dangling stack.yaml file

145030a

mpickering merged commit 2d432cd into master Nov 18, 2019

mpickering deleted the wip/tests branch November 18, 2019 23:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cradle tests #91

Add cradle tests #91

mpickering commented Nov 15, 2019

mpickering commented Nov 15, 2019

jneira commented Nov 16, 2019 •

edited

jneira commented Nov 16, 2019 •

edited

jneira commented Nov 16, 2019 •

edited

fendor Nov 16, 2019

mpickering Nov 16, 2019

fendor Nov 16, 2019

fendor Nov 16, 2019

fendor Nov 16, 2019

fendor Nov 16, 2019

fendor commented Nov 16, 2019

mpickering commented Nov 16, 2019

		@@ -0,0 +1,66 @@
		# This file was automatically generated by 'stack init'

Add cradle tests #91

Add cradle tests #91

Conversation

mpickering commented Nov 15, 2019

mpickering commented Nov 15, 2019

jneira commented Nov 16, 2019 • edited

jneira commented Nov 16, 2019 • edited

jneira commented Nov 16, 2019 • edited

fendor Nov 16, 2019

Choose a reason for hiding this comment

mpickering Nov 16, 2019

Choose a reason for hiding this comment

fendor Nov 16, 2019

Choose a reason for hiding this comment

fendor Nov 16, 2019

Choose a reason for hiding this comment

fendor Nov 16, 2019

Choose a reason for hiding this comment

fendor Nov 16, 2019

Choose a reason for hiding this comment

fendor commented Nov 16, 2019

mpickering commented Nov 16, 2019

jneira commented Nov 16, 2019 •

edited

jneira commented Nov 16, 2019 •

edited

jneira commented Nov 16, 2019 •

edited