Fix parsing of stores and loads in tests #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Test would only print any errors (e.g., parsing errors). Now it'll simply crash, making the failure obvious.
Apparently the current parser would fail on any memory accesses, both loads and stores. In case of the former it's enough to try parsing the memory accesses before variables. For stores, we can use backtracking so that we don't consume the initial "m" of memory assignemnt thinking that it's a variable identifier.
|
Rebased against the master, so everything should merge ok now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently testing/Parse was not able to parse memory accesses. This PR should fix this.
Also, now failing tests will error instead of just printing error message (since that by default is hidden by test-framework).