Fix dead code elimination used in tests #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper functions to fold over instructions and expressions in test/OptSupport have a bug where they would not recurse for complex expressions. And since testing/Live module depends on it, complex expressions would not be fully analyzed, leading to removal of code that is *not* dead, e.g., var1 = m[0] var1 = m[var1] + m[var1] would get rewritten to just var1 = m[var1] + m[var1] which is clearly wrong. Note that this bug affects only Hoopl's tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The helper functions to fold over instructions and expressions in
test/OptSupporthave a bug where they would not recurse for complexexpressions. And since
testing/Livemodule depends on it, complexexpressions would not be fully analyzed, leading to removal of code
that is not dead, e.g.,
would get rewritten to just
which is clearly wrong.
Note that this bug affects only Hoopl's tests.