Fix deprecation warnings from containers #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also bumps the lower bound on containers to `>= 0.5` which should be fine since `0.5.0.0` ws released in 2012.
|
This change breaks with ghc 7.0 but builds successfully with all later versions. |
mlite
previously requested changes
Feb 1, 2017
| mapFold k z (UM m) = M.fold k z m | ||
| mapFoldWithKey k z (UM m) = M.foldWithKey (k . intToUnique) z m | ||
| mapFold k z (UM m) = M.foldr k z m | ||
| mapFoldWithKey k z (UM m) = M.foldrWithKey (k . intToUnique) z m | ||
| mapFilter f (UM m) = UM (M.filter f m) |
There was a problem hiding this comment.
are fold and foldr equivalent?
There was a problem hiding this comment.
From the docs: "This function is an equivalent of foldr and is present for compatibility only."
The docs for foldWIthKey say it is equivalent to foldrWithKey.
erikd
dismissed
mlite’s stale review
Docs say the replacements are equivalent to the old functions.
|
The build failed. If we drop the support of 7.0.1, we need to delete " - CABALVER=1.16 GHCVER=7.0.1" from .travis.yml. Can you make this change too? Thanks. |
|
@mlite Should be good to go! |
|
Thanks @mlite ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bumps the lower bound on containers to
>= 0.5which should be finesince
0.5.0.0ws released in 2012.