Use non-deprecated Map and Set folds #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlite
reviewed
Feb 7, 2017
src/Compiler/Hoopl/Unique.hs
Outdated
| mapFold k z (UM m) = M.fold k z m | ||
| mapFoldWithKey k z (UM m) = M.foldWithKey (k . intToUnique) z m | ||
| mapFold k z (UM m) = M.foldr k z m | ||
| mapFoldWithKey k z (UM m) = M.foldrWithKey (k . intToUnique) z m | ||
| mapFilter f (UM m) = UM (M.filter f m) | ||
|
|
There was a problem hiding this comment.
Erikd made a change to fix M.fold and M.foldWithKey. The change was merged, however that change didn't fix S.fold. Please sync with the master, and resubmit the pull request. Thanks.
`fold` and `foldWithKey` are now deprecated in `containers`. This package's use causes GHC validation to fail with `containers-0.5.10.1`.
treeowl
force-pushed
the
use-non-deprecated-folds
branch
from
daf0c2e
to
46d43d4
Compare
|
I've rebased and resubmitted. We're going to need a hoopl release very soon
so GHC can upgrade containers.
…On Tue, Feb 7, 2017 at 10:36 AM, Ning ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Compiler/Hoopl/Unique.hs
<#37 (review)>:
> @@ -100,8 +100,8 @@ instance IsMap UniqueMap where
mapMap f (UM m) = UM (M.map f m)
mapMapWithKey f (UM m) = UM (M.mapWithKey (f . intToUnique) m)
- mapFold k z (UM m) = M.fold k z m
- mapFoldWithKey k z (UM m) = M.foldWithKey (k . intToUnique) z m
+ mapFold k z (UM m) = M.foldr k z m
+ mapFoldWithKey k z (UM m) = M.foldrWithKey (k . intToUnique) z m
mapFilter f (UM m) = UM (M.filter f m)
Erikd made a change to fix M.fold and M.foldWithKey. The change was
merged, however that change didn't fix S.fold. Please sync with the master,
and resubmit the pull request. Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABzi_RyI6PF_G_bcJc6LOtSoY7FWcXaxks5raI-AgaJpZM4L5KXF>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
foldandfoldWithKeyare now deprecated incontainers.This package's use causes GHC validation to fail with
containers-0.5.10.1.