Fix platformAwareUriToFilePath for empty paths #107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
platformAdjustFromUriPath
act asid
for empty paths.Ref haskell/haskell-ide-engine#713
Some tests in
test/unit/JsonSpec
fail when empty strings are passed toplatformAwareUriToFilePath
, thensplitDirectories
return empty list which then fails to pattern match onfirstSegment:rest
.I'm not sure if empty string is a valid value for
srcPath
or property tests should be altered to produce non-empty strings, though.