Rollback NFP interning #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright. Do you have any benchmarks? How are you checking these claims? Would something like an LRU cache help fix the space leaks? |
|
I am using telemetry metrics collected after running a patched version of Sigma IDE for a week. The results show that the RSS did actually increase for all percentiles. See haskell/haskell-language-server#1996 for a more localised approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In retrospect I don't think interning NFPs is a good idea. It can lead to space leaks, the efficiency gains are not that huge, and in some cases we can achieve the same efficiencies by carefully tweaking the call sites to maximise sharing.