Fix for #374 #376
Merged
Fix for #374 #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you going to try and tackle the fix too, or is this just to help someone else trying to do that? |
|
Plan to follow up with a fix eventually |
pepeiborra
force-pushed
the
executeCommand-head
branch
from
ea4f26c
to
ee623dd
Compare
pepeiborra
force-pushed
the
executeCommand-head
branch
from
ee623dd
to
32593ee
Compare
|
It would be a good idea to test this change against the HLS test suite before merging. |
|
Good thing I have a branch getting HLS to build with the latest LSP :) |
michaelpj
reviewed
Dec 16, 2021
| @@ -354,7 +354,10 @@ updateState (FromServerMess SWorkspaceApplyEdit r) = do | |||
| allChangeParams <- case r ^. params . edit . documentChanges of | |||
| Just (List cs) -> do | |||
| mapM_ (checkIfNeedsOpened . documentChangeUri) cs | |||
| return $ mapMaybe getParamsFromDocumentChange cs | |||
| -- replace the user provided version numbers with the VFS ones + 1 | |||
There was a problem hiding this comment.
why? are the user-provided ones wrong?
There was a problem hiding this comment.
the user can target a version older than the current one
| @@ -412,6 +414,8 @@ updateState (FromServerMess SWorkspaceApplyEdit r) = do | |||
| getParamsFromDocumentChange (InL textDocumentEdit) = Just $ getParamsFromTextDocumentEdit textDocumentEdit | |||
| getParamsFromDocumentChange _ = Nothing | |||
|
|
|||
| bumpNewestVersion (VersionedTextDocumentIdentifier uri _) = | |||
There was a problem hiding this comment.
I'd have to write that type signature myself, without the help of the IDE!! Unacceptable
pepeiborra
added a commit
to haskell/haskell-language-server
that referenced
this pull request
Dec 18, 2021
Grab and test haskell/lsp#376 as we want to include this bug fix for #2479
Testing in haskell/haskell-language-server#2494 |
pepeiborra
added a commit
to haskell/haskell-language-server
that referenced
this pull request
Dec 18, 2021
Grab and test haskell/lsp#376 as we want to include this bug fix for #2479
pepeiborra
added a commit
to haskell/haskell-language-server
that referenced
this pull request
Dec 18, 2021
Grab and test haskell/lsp#376 as we want to include this bug fix for #2479
pepeiborra
added a commit
to haskell/haskell-language-server
that referenced
this pull request
Dec 18, 2021
|
All tests passing now.. I found 2 completions tests in the func-test suite that were using I think we should merge this before the release |
This was referenced Dec 19, 2021
Closed
michaelpj
approved these changes
Dec 20, 2021
jneira
pushed a commit
to jneira/haskell-language-server
that referenced
this pull request
Dec 27, 2021
michaelpj
pushed a commit
to haskell/haskell-language-server
that referenced
this pull request
Dec 28, 2021
jneira
added a commit
to haskell/haskell-language-server
that referenced
this pull request
Dec 29, 2021
* Update to latest version of lsp libraries * Compute completions on kick This is not only for faster completions. It's also needed to have semi-fresh completions after editing. This is specially important for the first completion request of a file - without this change there are no completions available at all * Emit LSP custom messages on kick start/finish useful to synchonize on these events in tests * Fix completions tests after haskell/lsp#376 * Restore cabal update with comments * Use new lsp in stack 9.0.1 Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: jneira <atreyu.bbb@gmail.com>
drsooch
pushed a commit
to drsooch/haskell-language-server
that referenced
this pull request
Dec 29, 2021
* Update to latest version of lsp libraries * Compute completions on kick This is not only for faster completions. It's also needed to have semi-fresh completions after editing. This is specially important for the first completion request of a file - without this change there are no completions available at all * Emit LSP custom messages on kick start/finish useful to synchonize on these events in tests * Fix completions tests after haskell/lsp#376 * Restore cabal update with comments * Use new lsp in stack 9.0.1 Co-authored-by: Pepe Iborra <pepeiborra@gmail.com> Co-authored-by: jneira <atreyu.bbb@gmail.com> fix merge failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem only appears for
documentChangesedits.