New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTL doesn't adhere to PVP as it re-exports e.g. Control.Monad #68
Comments
would it be okay to just remove this? |
Remove re-export? I'd be very fine with that, the added convenience is minuscule IMO. |
I think we should just pull off the bandaid and do this. |
As the #99 is reverted this should be re-opened. |
So much for pulling off the bandaid. sigh |
I do want to go squarely on record as saying that reverting this change is the wrong decision. |
Yes. That level of impact is well within my expectation. This has been a wart in the design of this library that we've suffered with for 15 years, because at no point has it ever been "the right time to fix it." The thing is, waiting to fix it ever longer will simply increases our exposure without end. If our stated intention is to do this in 3.0 then all that we do by pushing this off is make sure that the substantive changes we want to make there to improve are conflated with this and ensuring we have even more code to unbreak. If our intention is not to do this in 3.0 then I really don't think this is maintenance, it is life support. |
The patches consist of adding imports, not making complicated semantic changes. The cost of the status quo is that adding any new combinators to With perfect hindsight, pulling this bandaid off when it was causing this pain to users more actively during the |
Why is it rational that Meanwhile, |
(fixed a typo) See #103 (comment) |
I do not see many developers suffering from this wart for 15 years. If that was the case, we'd see lots of packages choosing to import The breakage allows for backwards-compatible patches, which proponents of the change could have provided beforehand to alleviate the pain of migration. Yet I've seen no such effort underway in 2.5 years this ticket is open. I believe such a nuclear change, breaking all downstream dependencies, deserves a public presentation and community discussion before being made. A brief line in a changelog does not make it justice. |
There has been no effort underway on anything around the |
with |
This is subtle issue. But when you do
Then the
fail
is ambiguous.it's my own fault, that I imported
Control.Monad.Reader
unqualified, but still this is surprising and nasty.The text was updated successfully, but these errors were encountered: