Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove re-exports of Control.Monad, ... (#99)" #103

Merged
merged 1 commit into from Jan 28, 2022

Conversation

chessai
Copy link
Member

@chessai chessai commented Jan 19, 2022

This reverts commit 9e1582a.

cc @phadej @Bodigrim @emilypi

@chessai chessai mentioned this pull request Jan 26, 2022
8 tasks
@emilypi
Copy link
Member

emilypi commented Jan 28, 2022

FTR - not a fan of this. What's the point of this release if we don't rip of this particular bandaid along with the rest of the breaking changes? We're just punting the pain down the road (yet again)

@ekmett
Copy link
Member

ekmett commented Jan 28, 2022

I just want to go on the record saying that I'm very much against this decision. It was after all much of the reason for 2.3 being released at all, rather than jumping into the 3.0 release process.

@chessai
Copy link
Member Author

chessai commented Jan 28, 2022

After discussing it with @emilypi and considering everything, we've decided to reverse this decision.

We are going to provide a migration guide, and a writeup of our reasoning.

@emilypi is going to revert this revert later, and write a migration guide. Tonight or tomorrow I'm going to create the writeup with our reasoning.

@ysangkok
Copy link
Member

So is it better to test with rc3 than rc4? Since it still has the removed re-exports.

@andreasabel
Copy link
Member

Note that everything depending on ghc cannot upgrade mtl, unless ghc also upgrades the mtl it ships with. At least this is how I interpret the following error (with the RC under allow-newer: *:mtl and constraints: mtl==2.3):

[__2] trying: doctest-0.20.0 (dependency of BNFC *test)
[__3] trying: ghc-9.2.1/installed-9.2.1 (dependency of doctest)
[__4] trying: parsec-3.1.14.0/installed-3.1.14.0 (dependency of ghc)
[__5] trying: base-4.16.0.0/installed-4.16.0.0 (dependency of BNFC)
[__6] next goal: mtl (user goal)
[__6] rejecting: mtl-2.3 (conflict: parsec => mtl==2.2.2/installed-2.2.2)

Because doctest depends on ghc, everything using doctests can also not upgrade mtl.

This means that I cannot test the RC on many projects. I can only update such projects once a new ghc is released with the new mtl bundled with it.
Is that right? @emilypi @ekmett @chessai

@sjakobi
Copy link
Member

sjakobi commented Feb 18, 2022

@andreasabel AFAIK ghc's dependency on parsec and mtl will be removed in GHC 9.4: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/7472.

For now, I'd probably temporarily disable or remove the doctest dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants