Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.5.4.0 fails to compile with GHC 7.4.2 #16

Closed
peti opened this issue Oct 13, 2014 · 6 comments
Closed

Version 0.5.4.0 fails to compile with GHC 7.4.2 #16

peti opened this issue Oct 13, 2014 · 6 comments

Comments

@peti
Copy link

peti commented Oct 13, 2014

A complete build log is at http://hydra.cryp.to/build/201968/nixlog/1/raw

@hvr
Copy link
Member

hvr commented Oct 13, 2014

That's strange... why hasn't Travis caught this?

C.f. https://travis-ci.org/haskell/primitive/jobs/37707480

@hvr
Copy link
Member

hvr commented Oct 13, 2014

Oh... it's the testsuite that fails to compile w/ GHC 7.4 which isn't part of the Travis build-job;

@peti
Copy link
Author

peti commented Jan 17, 2015

Any news on this?

@hvr
Copy link
Member

hvr commented Jan 17, 2015

Fixing this is probably as easy as

diff --git a/test/main.hs b/test/main.hs
index 2e7ef0b..3289b43 100644
--- a/test/main.hs
+++ b/test/main.hs
@@ -15,7 +15,7 @@ main = do
             case writeArray arr 0 'B' of
                 IO f ->
                     case f realWorld# of
-                        _ -> ()
+                        (# _, _ #) -> ()
     c1 <- readArray arr 0
     return $! unit
     c2 <- readArray arr 0

@peti
Copy link
Author

peti commented Jan 17, 2015

OK. Is there anything I can do to help getting a new release to Hackage that has this fix included?

@RyanGlScott
Copy link
Member

This was fixed in #19. The current version on Hackage (0.6.1.0) also contains this fix, so I'm closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants