Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does removing a Cabal flag constitute a breaking change? #33

Open
sjakobi opened this issue Feb 28, 2021 · 3 comments
Open

Does removing a Cabal flag constitute a breaking change? #33

sjakobi opened this issue Feb 28, 2021 · 3 comments

Comments

@sjakobi
Copy link
Member

sjakobi commented Feb 28, 2021

This question came up in haskell/bytestring#371 (comment).

(CC @Bodigrim)

@phadej
Copy link
Collaborator

phadej commented Feb 28, 2021

The flag in question is automatic, and doesn't affect public API (AFAIK). So removing it is not breaking change, I don't see how any consumer could break. (EDIT: compare to just adding/removing a dependency, those aren't breaking by themself)

@Bodigrim
Copy link
Collaborator

Yeah, since cabal does not mind passing non-existent package flags, I do not see this as a breaking change.

@sjakobi
Copy link
Member Author

sjakobi commented Mar 1, 2021

since cabal does not mind passing non-existent package flags

Ah, this is the bit that I was confused about. I thought that a user explicitly setting that flag might run into upgrade troubles.

If this question is something that should be documented on the website, I'd leave this issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants