Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: missing BlockCodes ? #94

Closed
andreasabel opened this issue Sep 28, 2023 · 10 comments
Closed

Test failure: missing BlockCodes ? #94

andreasabel opened this issue Sep 28, 2023 · 10 comments

Comments

@andreasabel
Copy link
Member

andreasabel commented Sep 28, 2023

The CI on macOS for GHC 9.6 reports a failed test case (ICU_VER=73.2):
https://github.com/haskell/text-icu/actions/runs/6341389638/job/17224925448#step:11:26

t_blockCode: [Failed]
*** Failed! (after 76 tests):
Exception:
  toEnum{BlockCode}: tag (322) is outside of enumeration's range (0,320)
  CallStack (from HasCallStack):
    error, called at Data/Text/ICU/Char.hsc:485:17 in text-icu-0.8.0.2-inplace:Data.Text.ICU.Char
'\203257'

The Windows CI has a similar test failure (ICU_VER=73.2):
https://github.com/haskell/text-icu/actions/runs/6341389638/job/17224926997#step:11:25

  t_blockCode: [Failed]
*** Failed! (after 47 tests):
Exception:
  toEnum{BlockCode}: tag (322) is outside of enumeration's range (0,320)
  CallStack (from HasCallStack):
    error, called at Data\Text\ICU\Char.hsc:485:17 in text-icu-0.8.0.2-inplace:Data.Text.ICU.Char
'\201586'

These could be symptomatic that text-icu has fallen behind the ICU lib.
ICU 72 has Unicode 15, but currently only ICU 70 is supported.

I suppose this package needs some updates to the state of the art.
ATTN: @vshabanov

@andreasabel
Copy link
Member Author

https://github.com/haskell/text-icu/actions/runs/6361312691/job/17275646782#step:11:957

  t_blockCode: [Failed]
*** Failed! (after 7 tests):
Exception:
  toEnum{BlockCode}: tag (326) is outside of enumeration's range (0,320)
  CallStack (from HasCallStack):
    error, called at Data\Text\ICU\Char.hsc:485:17 in text-icu-0.8.0.2-74el0JRRzFBG38VQ4Hqf7Y:Data.Text.ICU.Char
'\73494'
(used seed 2000976820720826537)

@andreasabel
Copy link
Member Author

Same with '\202654'

@vshabanov
Copy link
Collaborator

Thank you, just uploaded text-icu-0.8.0.3 which fixes the issue.

@vshabanov
Copy link
Collaborator

Some of the tests fail now because they use the pre-72 version of ICU

@juhp
Copy link

juhp commented Oct 2, 2023

Yes I see for Stackage LTS:

             : [Failed]                                                                                                             
           expected: [ChessSymbols,CjkUnifiedIdeographsExtensionH,Kawi]                                                             
            but got: [ChessSymbols,NoBlock,NoBlock]           

It would be nice if there was some detection.

@andreasabel
Copy link
Member Author

Some of the tests fail now because they use the pre-72 version of ICU

CI on ubuntu-22.04 fails now always. This platform comes with ICU 70.1, see https://github.com/haskell/text-icu/actions/runs/6371163841/job/17292886318#step:8:17.
It would be good if text-icu worked smoothly for the latest Ubuntu LTSs (those shipped by github actions) also from the developer perspective. That means, cabal test should run out-of-the-box.

@juhp
Copy link

juhp commented Oct 2, 2023

We should probably open a new issue or reopen this one?

I need to allow the tests to fail in Nightly too

juhp added a commit to commercialhaskell/stackage that referenced this issue Oct 2, 2023
@andreasabel andreasabel reopened this Oct 2, 2023
@vshabanov
Copy link
Collaborator

Should be fixed in text-icu-0.8.0.4

@andreasabel
Copy link
Member Author

I deprecated 0.8.0.3 on hackage.

@juhp
Copy link

juhp commented Oct 9, 2023

If you would like the testsuite re-enabled in Stackage, please open a PR for that, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants