Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #280 (surrogate code points in Builder) #281

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Fix #280 (surrogate code points in Builder) #281

merged 2 commits into from
Mar 31, 2021

Conversation

minoki
Copy link
Contributor

@minoki minoki commented Apr 16, 2020

This PR fixes #280.

@Lysxia Lysxia added the fix:bug label Mar 7, 2021
@Lysxia
Copy link
Contributor

Lysxia commented Mar 24, 2021

This looks pretty straightforward. @minoki would you like to rebase?

@minoki
Copy link
Contributor Author

minoki commented Mar 24, 2021

@Lysxia Done.

@Lysxia
Copy link
Contributor

Lysxia commented Mar 24, 2021 •
edited
Loading

Aside from that, is there a similar issue with the uses of unsafeWrite in Data.Text.Internal.Lazy.Fusion? One can inject arbitrary Char using unfoldrN. It's an internal function used in Data.Text where validation is ensured at each use site.

@Lysxia Lysxia merged commit 160cec6 into haskell:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bodigrim Bodigrim Bodigrim approved these changes

@Lysxia Lysxia Lysxia approved these changes

Assignees
No one assigned
Labels
fix:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Builder.fromString and Builder.singleton don't substitute surrogate code points
3 participants
@minoki @Lysxia @Bodigrim