Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make toCaseFold idempotent #402

Merged
merged 3 commits into from
Jan 2, 2022
Merged

Make toCaseFold idempotent #402

merged 3 commits into from
Jan 2, 2022

Conversation

Bodigrim
Copy link
Contributor

@Bodigrim Bodigrim commented Jan 1, 2022

Fixes #277.

Lysxia
Lysxia approved these changes Jan 2, 2022
View reviewed changes
Copy link
Contributor

@Lysxia Lysxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The main difference is that the 96 uppercase cherokee characters are no longer mapped in src/.../CaseMapping.hs. The remaining differences in that file are just reordering of lines and added comments naming code points.

@Lysxia Lysxia merged commit 02ee677 into haskell:master Jan 2, 2022
@Bodigrim Bodigrim deleted the cherokee branch August 14, 2022 21:00
@phadej phadej mentioned this pull request Feb 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lysxia Lysxia Lysxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with cherokee characters & toCaseFold
2 participants
@Bodigrim @Lysxia