Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lift instances more efficient #413

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

TeofilC
Copy link
Contributor

@TeofilC TeofilC commented Mar 4, 2022

This patch allows the Lift instance to make use of the primitive bytes literals made available since template-haskell 2.16.

It also adds some extra tests to make sure the instance works correctly with multi codepoint characters.

Let me know if you'd like some changes

@Bodigrim
Copy link
Contributor

Bodigrim commented Mar 5, 2022

@phadej could you please review?

@TeofilC
Copy link
Contributor Author

TeofilC commented Mar 5, 2022

The CI failures seem to be due to the change in template-haskell 2.17 for the type of lift from a -> Q a to Quote m => a -> m a. I'll push a fix

@TeofilC
Copy link
Contributor Author

TeofilC commented Mar 14, 2022

I've force pushed to squash the fixup commit

@TeofilC
Copy link
Contributor Author

TeofilC commented Mar 14, 2022

Ah dear it seems like I dropped that commit by accident instead of squashing it. I'll fix it in a bit

@Bodigrim
Copy link
Contributor

I'll squash all commits any way, so do not worry about that.

@Bodigrim Bodigrim merged commit f256cbb into haskell:master Mar 15, 2022
@Bodigrim
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants