Don't link against libgcc_s on Windows with GHC 9.4 and later #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of GHC 9.4 we use libc+++ and Clang on Windows.
bgamari
force-pushed
the
wip/windows-clang
branch
2 times, most recently
from
d36ce2e
to
f74ec15
Compare
|
bgamari
force-pushed
the
wip/windows-clang
branch
from
f74ec15
to
933a3e8
Compare
Sigh, quite right. I'll fix.
Hmm, yes, I didn't read that comment closely enough. Indeed we likely shouldn't use these on Windows. |
Bodigrim
approved these changes
Apr 25, 2022
|
@bgamari thanks, please rebase. |
|
Nevermind, I can squash on my end. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of GHC 9.4 we use libc+++ and Clang on Windows.