Allow bytestring-0.12 #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasufell
reviewed
Jul 8, 2023
| @@ -133,7 +133,7 @@ putEnv (PS fp o l) = withForeignPtr fp $ \p -> do | |||
| -- | |||
| -- hence we must not free the buffer | |||
| buf <- mallocBytes (l+1) | |||
| memcpy buf (p `plusPtr` o) l | |||
| copyBytes buf (p `plusPtr` o) l | |||
There was a problem hiding this comment.
I can confirm that copyBytes exists since at least base-4.9.1.0.
hasufell
approved these changes
Jul 8, 2023
Bodigrim
approved these changes
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unixdoes not use any of the functions that have changed behavior inbytestring-0.12.0.0, so the bound-bump is safe. (See the changelog.)I've also replaced the one use of the now-deprecated
Data.ByteString.Internal.memcpywith the equivalentForeign.Marshal.Utils.copyBytes.