Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing API master issue #262

Closed
merijn opened this issue Dec 15, 2019 · 5 comments · Fixed by #320
Closed

Missing API master issue #262

merijn opened this issue Dec 15, 2019 · 5 comments · Fixed by #320
Milestone

Comments

@merijn
Copy link

merijn commented Dec 15, 2019

This issue is to document functions that are in some of the vector modules, but not others. I will update and add missing functions as I find them:

Not anywhere, but nice to have:

  • iforM
  • iforM_

Mutable modules should probably re-export PrimState and PrimMonad so it's easier to write PrimMonad generic code without adding the additional primitive dependency and an extra import.

Data.Vector.Storable:

  • imapM
  • imapM_
@cartazio
Copy link
Contributor

cartazio commented Dec 15, 2019 via email

@merijn
Copy link
Author

merijn commented Dec 15, 2019

Right now I'm just writing down everything I'm having to reimplement to get my stuff working >.>
A substantial number are already in Data.Vector.Generic, so I'm unsure why they aren't exported already.

@merijn
Copy link
Author

merijn commented May 28, 2020

Edit: actually, they're just under a different heading, nevermind!

@cartazio
Copy link
Contributor

cartazio commented May 28, 2020 via email

fumieval added a commit to fumieval/vector that referenced this issue Jun 6, 2020
fumieval added a commit to fumieval/vector that referenced this issue Jun 6, 2020
fumieval added a commit to fumieval/vector that referenced this issue Jun 7, 2020
lehins added a commit that referenced this issue Jun 8, 2020
Implement iforM and iforM_ (#262)
@Shimuuar
Copy link
Contributor

Shimuuar commented Jun 8, 2020

This leaves only

Mutable modules should probably re-export PrimState and PrimMonad so it's easier to write PrimMonad generic code without adding the additional primitive dependency and an extra import.

I think it's fair request and won't cause name clashes since module is expected to imported qualified

@Shimuuar Shimuuar added this to the 0.13 milestone Jun 11, 2020
Shimuuar added a commit to Shimuuar/vector that referenced this issue Jun 20, 2020
This allows to avoid extra import from primitive (and adding it to cabal file)
It's also in line with reexposrt of Storable and Prim type classes

Fixes haskell#262
Shimuuar added a commit that referenced this issue Jun 23, 2020
* Reexport PrimMonad from mutable vectors

This allows to avoid extra import from primitive (and adding it to cabal file)
It's also in line with reexposrt of Storable and Prim type classes

Fixes #262

* Reexport RealWorld per @lehins suggestion

Also move reexports to bottom of module per @Bodigrim suggestion
lehins pushed a commit that referenced this issue Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants