make Data.Vector.Generic.Base.Mutable injective #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartazio
previously requested changes
May 26, 2017
| @@ -24,9 +28,13 @@ import qualified Data.Vector.Generic.Mutable.Base as M | |||
| import Control.Monad.Primitive | |||
|
|
|||
| -- | @Mutable v s a@ is the mutable version of the pure vector type @v a@ with | |||
| -- the state token @s@ | |||
| -- the state token @s@. It is injective on GHC 8 and newer. | |||
| -- | |||
There was a problem hiding this comment.
Might be good to have 1-2 tests that validate that injectivity work on small examples that run when new enough ghc is available :)
There was a problem hiding this comment.
See tests/Tests/Vector/UnitTests.hs.
|
In the interest of moving this along, I've pushed a commit which adds a test for |
|
@cartazio, does this need any more changes before being merged? |
|
Looks good to me. |
cartazio
pushed a commit
that referenced
this pull request
Dec 7, 2018
* make Data.Vector.Generic.Base.Mutable injective * Add test, use __GLASGOW_HASKELL_
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #34