Implement unfoldrExactN & unfoldrExactNM #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
reviewed
Feb 2, 2020
Data/Vector.hs
Outdated
| @@ -691,6 +691,15 @@ unfoldrN :: Int -> (b -> Maybe (a, b)) -> b -> Vector a | |||
| {-# INLINE unfoldrN #-} | |||
| unfoldrN = G.unfoldrN | |||
|
|
|||
| -- | /O(n)/ Construct a vector with at most @n@ elements by repeatedly applying | |||
| -- the generator function to a seed. The generator function yields 'Just' the | |||
| -- next element and the new seed or 'Nothing' if there are no more elements. | |||
There was a problem hiding this comment.
Here and other places the doc was copy pasted and needs fixing.
Data/Vector/Fusion/Stream/Monadic.hs
Outdated
| {-# INLINE_FUSED unfoldrExactN #-} | ||
| unfoldrExactN n f = unfoldrExactNM n (return . f) | ||
|
|
||
| -- | Unfold at most @n@ elements with a monadic functions |
There was a problem hiding this comment.
Should say Unfold exactly @n@ elements ...
There was a problem hiding this comment.
And I thought I fixed haddock... Thanks! I guess I mixed up copy-paste somewhere
There was a problem hiding this comment.
The doc is still not right :)
Should say: Unfold exactly @n@ elements with a monadic function
(note function is not plural)
Shimuuar
force-pushed
the
kh/unfoldr-exact
branch
from
457009d
to
021f57b
Compare
|
I think I fixed haddocks |
lehins
reviewed
Feb 10, 2020
Data/Vector/Fusion/Bundle.hs
Outdated
| @@ -437,6 +437,11 @@ unfoldrN :: Int -> (s -> Maybe (a, s)) -> s -> Bundle v a | |||
| {-# INLINE unfoldrN #-} | |||
| unfoldrN = M.unfoldrN | |||
|
|
|||
| -- | Unfold at most @n@ elements | |||
There was a problem hiding this comment.
Same here:
Unfold exactly @n@ elements
Shimuuar
force-pushed
the
kh/unfoldr-exact
branch
from
021f57b
to
1052844
Compare
Shimuuar
force-pushed
the
kh/unfoldr-exact
branch
from
1052844
to
8cf8345
Compare
|
I made a minor adjustment to this PR: lehins@ccc6e50 Once the CI passes it will be good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140