Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appveyor support #41

Merged
merged 1 commit into from Dec 23, 2015
Merged

Add Appveyor support #41

merged 1 commit into from Dec 23, 2015

Conversation

ndmitchell
Copy link
Contributor

Requested by @hvr.

@hvr
Copy link
Member

hvr commented Dec 23, 2015

Do I need to do anything to make this work? :-)

@ndmitchell
Copy link
Contributor Author

You can see the results at https://ci.appveyor.com/project/ndmitchell/win32. You should sign up for an appveyor account and then add it (very easy), and it will build automatically.

Note this is my standard Stack appveyor setup. I tend to do aggressive checks on Travis (no \r newlines, no missing files in the Cabal list, no warnings etc), and then leave appveyor to just check it builds/passes tests. Given this project, you may want to insert some -Werror into it somewhere.

@hvr
Copy link
Member

hvr commented Dec 23, 2015

Well, problem is, we can't use Travis at all, because Win32 is a windows-only package... :-)

@ndmitchell
Copy link
Contributor Author

Merge. Get an Appveyor account. Log into Appveyor. Projects. Add Project. Win32 (+). That's about it, very smooth.

Yep, I appreciate my standard approach will fail here, so you might need to push more into Appveyor, while I keep it deliberately light.

hvr added a commit that referenced this pull request Dec 23, 2015
@hvr hvr merged commit 14550e8 into haskell:master Dec 23, 2015
@hvr
Copy link
Member

hvr commented Dec 23, 2015

one last question: say I wanted to enable -Werror or some other ghc warning flags for the validation... how would I do that?

@ndmitchell
Copy link
Contributor Author

Change the stack build line to include things like --ghc-options -Werror, I think, but I'm not an expert there.

bgamari pushed a commit to bgamari/win32 that referenced this pull request Sep 10, 2020
Fix withInterrupt function docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants