-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bip340 support #40
base: master
Are you sure you want to change the base?
Bip340 support #40
Conversation
a359ed6
to
e774655
Compare
There has been some discussion about whether to include this now that taproot is active over in |
Note that my patch was for a pre-release version of secp256k1. It might still be resurrectable, but I wanted to mention that. |
@jprupp Can this be merged now that Ubuntu 24.04 is out and all target distributions have schnorr support? |
Resolve conflicts, and then I'll review with intention to merge. |
e774655
to
cf4acb8
Compare
I resolved the conflicts and tried to make the code as consistent as possible with the existing bindings. |
cf4acb8
to
c3de3ad
Compare
This change adds bindings to the schnorr signing functionality in
libsecp256k1
, but behind a flag. The versions oflibsecp256k1
that ship with popular linux distros do not have this functionality enabled. However,nix
users can add the followingshell.nix
to explore the changes:As long as they are using a recent version of
nixpkgs
.