New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop -D_GLIBCXX_USE_CXX11_ABI=0 #166

Merged

junjihashimoto merged 1 commit into hasktorch:master from junjihashimoto:feature/c++11abi

Sep 3, 2019

Member

junjihashimoto commented Sep 2, 2019 •

edited

libtorch begins to provide binaries using C++11ABI.
(Old C++ABI with -D_GLIBCXX_USE_CXX11_ABI=0 is to keep backward compatibility for nvcc using gcc-4.)
https://discuss.pytorch.org/t/issues-linking-with-libtorch-c-11-abi/29510/2
#162

This PR changes the C++ABI to C++11ABI.


          Drop -D_GLIBCXX_USE_CXX11_ABI=0

a74e763

Member

tscholak commented Sep 2, 2019

ah, now I understand why @wavewave did that ;)

junjihashimoto merged commit 334afb9 into hasktorch:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment