-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typeclasses and dimensions-0.3.2.0 #42
Conversation
Let's get this merged @stites, can you submit the PR to a staging branch so we can resolve fixes without breaking the master branch? |
…een static and dims
Yep. So I just rebased this and need to review some changes. Issues I saw in the rebase:
|
everything builds and @austinvhuang tell me what you think about the PR -- I think it's ready at this point, even though FloatMath has been commented out (it seems to be a c/p of DoubleMath, and I'd prefer to port DoubleMath to a generic version, like how Static.Generic is really a refactored Static.Double). The code as-is shouldn't be considered complete, there is still a lot of reorganizing that I think needs to happen before a release, but merging this moves us back to smaller PRs. |
Merged. Great work @stites! The aten function update should be easily patched, and as I mentioned in slack, it's probably time for an upstream refresh since they've been adding some other probability density related functions to TensorMath. |
👍 cool beans! I'm also getting a better sense of what the typeclass-based interface would look like (it's not super crazy) for the higher-level |
Typeclasses and dimensions-0.3.2.0
* Starting point for Hasktorch 0.2 interface * Flesh out basic functionality in the new interface * Working XOR MLP * Add the independent function * Aten -> ATen * Add hasktorch and examples to CI * Add side-effect for ones * Make autograd safer
See #39 for description. Closes #18.
The private-to-public switch did something to my fork and blocked me from updating #39, so I'm closing it in favor of this PR.