Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeclasses and dimensions-0.3.2.0 #42

Merged
merged 38 commits into from
Jan 9, 2018
Merged

Conversation

stites
Copy link
Member

@stites stites commented Jan 4, 2018

See #39 for description. Closes #18.

The private-to-public switch did something to my fork and blocked me from updating #39, so I'm closing it in favor of this PR.

@austinvhuang
Copy link
Member

Let's get this merged @stites, can you submit the PR to a staging branch so we can resolve fixes without breaking the master branch?

@stites
Copy link
Member Author

stites commented Jan 7, 2018

Yep. So I just rebased this and need to review some changes. Issues I saw in the rebase:

  • TensorRaw started porting code to do operations on RawTensorLong. This is unnecessary as the generic functions can handle all tensor types.
  • nn got deleted in master???
  • examples are still broken due to compile errors. Also hasktorch-examples:exe:ad changed significantly, so reverted back to master's version. See next comment

@stites
Copy link
Member Author

stites commented Jan 8, 2018

everything builds and stack test works, sans standard_gamma functions, which are new in ATen. I commented out these functions for now so that they would build on my machine which has an older .so, but I think it would also make a good first issue for someone to reintroduce this code -- @omaclaren, maybe?

@austinvhuang tell me what you think about the PR -- I think it's ready at this point, even though FloatMath has been commented out (it seems to be a c/p of DoubleMath, and I'd prefer to port DoubleMath to a generic version, like how Static.Generic is really a refactored Static.Double). The code as-is shouldn't be considered complete, there is still a lot of reorganizing that I think needs to happen before a release, but merging this moves us back to smaller PRs.

@austinvhuang austinvhuang merged commit 92f79a6 into hasktorch:master Jan 9, 2018
@austinvhuang
Copy link
Member

Merged. Great work @stites! The aten function update should be easily patched, and as I mentioned in slack, it's probably time for an upstream refresh since they've been adding some other probability density related functions to TensorMath.

@stites
Copy link
Member Author

stites commented Jan 10, 2018

👍 cool beans! I'm also getting a better sense of what the typeclass-based interface would look like (it's not super crazy) for the higher-level Dynamic and Static modules.

@stites stites deleted the dims branch August 27, 2018 18:14
stites pushed a commit to stites/hasktorch that referenced this pull request Sep 9, 2018
Typeclasses and dimensions-0.3.2.0
stites pushed a commit to stites/hasktorch that referenced this pull request Aug 4, 2019
* Starting point for Hasktorch 0.2 interface

* Flesh out basic functionality in the new interface

* Working XOR MLP

* Add the independent function

* Aten -> ATen

* Add hasktorch and examples to CI

* Add side-effect for ones

* Make autograd safer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants