Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added antnet simulation #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added antnet simulation #27

wants to merge 2 commits into from

Conversation

shubhomoy
Copy link

Separated out the codebase done in course with few tweaks to get it running

@hasnainroopawalla hasnainroopawalla added the enhancement New feature or request label Jan 5, 2022
hasnainroopawalla
hasnainroopawalla requested changes Jan 5, 2022
View reviewed changes
Copy link
Owner

@hasnainroopawalla hasnainroopawalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Few points:

  • Can you move the antnet package to the showml.simulations package?
  • Add docstring descriptions to the methods and variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasnainroopawalla hasnainroopawalla hasnainroopawalla requested changes

Assignees

@shubhomoy shubhomoy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shubhomoy @hasnainroopawalla