Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix api #51

Merged
merged 8 commits into from
Jan 5, 2021
Merged

Fix api #51

merged 8 commits into from
Jan 5, 2021

Conversation

alexyao2015
Copy link
Member

Fixes issue where RGBWW lights didn't show both the color wheel and temp wheel. Various tweaks

@alexyao2015 alexyao2015 mentioned this pull request Jan 5, 2021
Closed
marcelveldt
marcelveldt requested changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the import is in the wrong order

marcelveldt
marcelveldt approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this in and do some testing!

emulated_hue/api.py Show resolved Hide resolved
emulated_hue/api.py Show resolved Hide resolved
@alexyao2015
Copy link
Member Author

the import is in the wrong order

Which import?

@marcelveldt marcelveldt merged commit d365984 into master Jan 5, 2021
@marcelveldt marcelveldt deleted the fix-api branch January 5, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelveldt marcelveldt marcelveldt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexyao2015 @marcelveldt