Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoxyFileman dies on interpreting an invalid image #89

Closed
hassanelsherbiny opened this issue Mar 6, 2024 · 0 comments
Closed

RoxyFileman dies on interpreting an invalid image #89

hassanelsherbiny opened this issue Mar 6, 2024 · 0 comments

Comments

@hassanelsherbiny
Copy link
Owner

version: 4.60.5

Steps to reproduce the problem:

  1. Create an empty file in wwwroot/images/uploaded
  2. Rename it to resemble an image file (e.g. test.png)
  3. Try to use an image uploader in any WYSIWYG

RoxyFileman will stop working when this happens, as the call on RoxyFilemanFileProvider.cs#396 returns null and the next line throws an exception.

Expected behavior:

  • Do not list invalid images;
    or
  • List invalid images with some warning;
    or
  • Send a meaningful error message containing the problematic file's path relative to RoxyFileman root.
hassanelsherbiny added a commit that referenced this issue Mar 10, 2024
…erpreting-an-invalid-image-#89

RoxyFileman dies on interpreting an invalid image #89
hassanelsherbiny added a commit that referenced this issue May 3, 2024
…erpreting-an-invalid-image-#89

RoxyFileman dies on interpreting an invalid image #89
hassanelsherbiny added a commit that referenced this issue May 3, 2024
…erpreting-an-invalid-image-#89

RoxyFileman dies on interpreting an invalid image #89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant