CODE RUB: Upgrade Student Exceptions Add to The new Standard #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stsAndLogItAsync -> FAIL
…xistsAndLogItAsync -> FAIL
…xistsAndLogItAsync -> FAIL
…xistsAndLogItAsync -> PASS
…students-register
…dLogItAsync -> FAIL
…dLogItAsync -> PASS
…ogItAsync -> PASS
|
@cacti79 make sure that you go to Visual Studio -> Tools -> Options then make sure your code clean up puts System Directives first always.
|
|
@hassanhabib Thanks, Based on the last PR that you upgrade to a new standard but there was no FailedStudentStorageException, I tried to make it similar to what we did in Taarafo, |
hassanhabib
reviewed
Oct 18, 2021
OtripleS.Web.Api.Tests.Unit/Services/Foundations/Students/StudentServiceTests.Exceptions.Add.cs
Outdated
Show resolved
Hide resolved
hassanhabib
reviewed
Oct 18, 2021
OtripleS.Web.Api.Tests.Unit/Services/Foundations/Students/StudentServiceTests.Exceptions.Add.cs
Outdated
Show resolved
Hide resolved
hassanhabib
reviewed
Oct 18, 2021
OtripleS.Web.Api.Tests.Unit/Services/Foundations/Students/StudentServiceTests.Exceptions.Add.cs
Show resolved
Hide resolved
hassanhabib
reviewed
Oct 18, 2021
OtripleS.Web.Api/Services/Foundations/Teachers/TeacherService.Validations.cs
Outdated
Show resolved
Hide resolved
This was referenced Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on that we work on Taarafo.