MINOR FIX: Enable Optional Stringification of Properties as StringCon… #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "text/json" => ConvertToJsonString(propertyValue, ignoreDefaultValues), | ||
| "application/json" => ConvertToJsonString(propertyValue, ignoreDefaultValues), | ||
| _ => propertyValue.ToString() |
There was a problem hiding this comment.
We should guard for null propertyValue. This code path is triggered when property has a default value of null and we don't ignore default values.
Suggested change
| _ => propertyValue.ToString() | |
| _ => propertyValue?.ToString() |
|
@BrianLParker @Catalin-Andronie I will review this well. |
hassanhabib
reviewed
May 24, 2023
| @@ -109,7 +109,7 @@ private static string ConvertToString(object propertyValue, string mediaType, bo | |||
| { | |||
| "text/json" => ConvertToJsonString(propertyValue, ignoreDefaultValues), | |||
| "application/json" => ConvertToJsonString(propertyValue, ignoreDefaultValues), | |||
| _ => propertyValue.ToString() | |||
| _ => propertyValue?.ToString() | |||
There was a problem hiding this comment.
Where's the test for this Null Guard?
There was a problem hiding this comment.
This is still draft the tests are coming. I need to talk re tests and optional serialization as well.
Co-authored-by: Cătălin Andronie <catalin.andronie@gmail.com>
|
@hassanhabib @BrianLParker any news about this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hassanhabib @Catalin-Andronie
Closes #130
Closes #132
POC Repo (Reference this branch ...)
Output Screenshot
