Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test enhancement #126

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Test enhancement #126

merged 1 commit into from
Mar 1, 2020

Conversation

peter279k
Copy link
Contributor

Changed log

  • Using the install option via composer install is good enough to install required dependencies on Travis CI build.
  • The PHPUnit\Framework\TestCase namespace is supported since PHPUnit version is 4.8.36.
  • Using the assertInternalType assertion to determine the expected type is array.
  • Using the assertFileEquals to assert the expected contents of file is same as resulted contents of file.

@DavidePastore DavidePastore added this to the Future Release milestone Mar 1, 2020
@DavidePastore
Copy link
Collaborator

Thanks for your PR! 😄

@DavidePastore DavidePastore merged commit 188d2b6 into hassankhan:develop Mar 1, 2020
@peter279k peter279k deleted the test_enhancement branch March 1, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peter279k @DavidePastore