-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for the end of life PHP versions #149
Drop support for the end of life PHP versions #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nbayramberdiyev. Thanks for this! Could you please also remove the yoast/phpunit-polyfills
dependency and its usages? It was used only to ensure that the PHP tests are executable also on old PHP Unit versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look at the following comment: #149 (review)
Done in |
Thanks for your effort on this PR, @nbayramberdiyev. |
Closes #144