Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敤Fix websockets connectivity #16

Merged
merged 9 commits into from
Jan 2, 2020

Conversation

sinclairpaul
Copy link
Member

@sinclairpaul sinclairpaul commented Dec 19, 2019

Proposed Changes

As per https://github.com/dani-garcia/bitwarden_rs/wiki/Enabling-WebSocket-notifications
Rocket does not support Websockets, so they must be proxied through a reverse proxy to work.

Summary of changes:

  • Add nginx and standard config to image
  • Move SSL to nginx
  • Change Rocket port internally to 80, Websockets endpoint to 8080 (always listening)
  • Remove websocket port from exposed list as it is not used (everything is proxied through 7277)
  • Align Max Body Size in Nginx with config value

I have tested between the Web App, Chrome extension and Android app. Prior to changes the apps would need to be refreshed to get updated entries, after they appear automatically.

Related Issues

None

GitHub
Unofficial Bitwarden compatible server written in Rust - dani-garcia/bitwarden_rs

@addons-assistant
Copy link

馃挅 Thanks for opening this pull request! 馃挅 If your PR gets accepted and merged in, we will invite you to the project 馃帀

@reharmsen
Copy link
Contributor

I already have a ngix proxy with the correct configuration running in my HassOS instance with ngix proxy manager.
Ngix Proxy Manager also manages my Let's Encrypt certificates.

Can I still use this to have my certificates managed?

@sinclairpaul
Copy link
Member Author

I already have a ngix proxy with the correct configuration running in my HassOS instance with ngix proxy manager.
Ngix Proxy Manager also manages my Let's Encrypt certificates.

Can I still use this to have my certificates managed?

@reharmsen Yes, but as this is not merged yet, the comments are really for review.

@reharmsen
Copy link
Contributor

reharmsen commented Dec 20, 2019

I already have a ngix proxy with the correct configuration running in my HassOS instance with ngix proxy manager.
Ngix Proxy Manager also manages my Let's Encrypt certificates.
Can I still use this to have my certificates managed?

@reharmsen Yes, but as this is not merged yet, the comments are really for review.

I am just worried something could break or not possible.
I guess others will better be able to judge that.

Changing this, might make the configuration a lot simpler.

bitwarden/rootfs/etc/nginx/nginx.conf Outdated Show resolved Hide resolved
bitwarden/rootfs/etc/nginx/includes/resolver.conf Outdated Show resolved Hide resolved
bitwarden/Dockerfile Outdated Show resolved Hide resolved
bitwarden/Dockerfile Show resolved Hide resolved
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃憤

Thanks m8!

Happy New Year! 馃嵕

@frenck frenck merged commit c6387c8 into hassio-addons:master Jan 2, 2020
@addons-assistant
Copy link

Congrats on merging your first pull request! 馃帀馃帀馃帀

@addons-assistant
Copy link

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@addons-assistant addons-assistant bot locked as resolved and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants