-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃敤Fix websockets connectivity #16
Conversation
馃挅 Thanks for opening this pull request! 馃挅 If your PR gets accepted and merged in, we will invite you to the project 馃帀 |
I already have a ngix proxy with the correct configuration running in my HassOS instance with ngix proxy manager. Can I still use this to have my certificates managed? |
@reharmsen Yes, but as this is not merged yet, the comments are really for review. |
I am just worried something could break or not possible. Changing this, might make the configuration a lot simpler. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 馃憤
Thanks m8!
Happy New Year! 馃嵕
Congrats on merging your first pull request! 馃帀馃帀馃帀 |
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Proposed Changes
As per https://github.com/dani-garcia/bitwarden_rs/wiki/Enabling-WebSocket-notifications
Rocket does not support Websockets, so they must be proxied through a reverse proxy to work.
Summary of changes:
I have tested between the Web App, Chrome extension and Android app. Prior to changes the apps would need to be refreshed to get updated entries, after they appear automatically.
Related Issues
None