Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RON is not supported as a currency #35

Closed
johnflorin opened this issue Jul 10, 2019 · 5 comments
Closed

RON is not supported as a currency #35

johnflorin opened this issue Jul 10, 2019 · 5 comments

Comments

@johnflorin
Copy link

Problem/Motivation

I tried to configure the addon to work with RON as a currency and it would not save products properly or allow me to add to Inventory.

Expected behavior

I add a new product and get the green confirmation in the corner and I can then add it to the Inventory.

Actual behavior

When confirming the adding of a new product, the final step results in a Page Not Found error and when I try to use that product to add it to the Inventory, the green confirmation is grayed out even though I filled in all the fields. It works fine if I use the addon with USD.

Steps to reproduce

Input "currency": "RON" in the addon config and try to add a product and use it in the Inventory.

Proposed changes

Either add support for all ISO 4217 currencies, or change the documentation, which right now says:

Option: currency

**_Determines the currency as displayed in the Grocy interface, specified by the ISO4217 three digit currency code.

Examples: USD, CAD, GBP or EUR._**

@addons-assistant
Copy link

👋 Thanks for opening your first issue here! If you're reporting a 🐛 bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be usefull.

@sinclairpaul
Copy link
Member

Can you confirm if this only occurs when using Ingress, i.e. if you expose the port for the addon and use that, it functions fine?

This is the behavior that I am seeing.

@johnflorin
Copy link
Author

This seems to be the case, although I didn't expose a specific port just for the addon...when using the Ingress link, I get a 404 after adding a product, when using my HA DuckDNS link, it works fine and with any currency in the config as well (in both cases I am accessing the addon from the side panel as configured via "Show in sidebar").

@addons-assistant
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@addons-assistant
Copy link

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@addons-assistant addons-assistant bot locked as resolved and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants