Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements after first iteration #1

Merged
merged 4 commits into from
Jun 12, 2022
Merged

Improvements after first iteration #1

merged 4 commits into from
Jun 12, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Feb 3, 2022 •
edited
Loading

Proposed Changes

  • Remove default configuration (as that is not universal)
  • Add option to configure the location of the MQTT IO configuration file
  • Fail with an extensive error message in case configuration file does not exists
  • Updates docs for the new configuration option
  • Added instructions to installation about how to get started/creating a config file

TODO:

  • Exit container on process failure
  • Copy bare bone config files in place for new configurations, and make sure it contains basic MQTT configuration

@frenck frenck marked this pull request as draft February 3, 2022 13:07
@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Feb 3, 2022
@frenck frenck marked this pull request as ready for review February 3, 2022 13:15
@frenck frenck marked this pull request as draft February 3, 2022 13:38
@frenck frenck changed the title Add option to specify configuration file location Improvements after first iteration Feb 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Mar 6, 2022
@github-actions github-actions bot closed this Mar 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2022
@thecode thecode reopened this Apr 17, 2022
@thecode thecode removed the stale There has not been activity on this issue or PR for quite some time. label Apr 17, 2022
@frenck frenck marked this pull request as ready for review June 12, 2022 20:54
@frenck frenck merged commit d6e237a into main Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frenck @thecode