Add permissions for serial devices (fixes #32) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles devices in /dev/tty and /dev/serial
|
💖 Thanks for opening this pull request! 💖 If your PR gets accepted and merged in, we will invite you to the project 🎉 |
|
We should not mess with devices provided by Home Assistant. |
|
@frenck I should report in the supervisor repo? |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds permissions fix for
/dev/tty*devices and devices in/dev/serial. I tested with only the/dev/tty*line and it seems that the/dev/serialline is necessary.This is following a discussion on Discord with @sinclairpaul. Basically I had been running an old local version of this addon (from before it was made available in the community repo and before
auto_uartwas added or the auto-config file updates worked) and was trying to upgrade it. I went back through it and found I made this change to make it work.Related Issues
#32