Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Drop 0.9.0 vs 0.10.0 #168

Closed
GoetzGoerisch opened this issue Mar 31, 2023 · 22 comments
Closed

Performance Drop 0.9.0 vs 0.10.0 #168

GoetzGoerisch opened this issue Mar 31, 2023 · 22 comments
Labels
stale There has not been activity on this issue or PR for quite some time.

Comments

@GoetzGoerisch
Copy link

Problem/Motivation

Using HA with Tailscale as an exit node crippled the througput between v0.9.0 and v0.10.0.

Expected behavior

With version 0.9.0 one could achive about line speed, which is about 50MBit in my case with a raspberry-pi-4 using a smartphone and run all traffic through HA.

Actual behavior

Speed is crippled to about 1Mbit.

Steps to reproduce

  • Advertise HA with Tailscale add-on as Exit Node
  • Use exit node in mobil Tailscale app
  • Run a speedtest with 0.9.0 and 0.10.0

Proposed changes

Investigate the impact of added taildrop on throughput.

@GoetzGoerisch
Copy link
Author

Just ran a test with v0.9.0 and v0.10.0.

Until about -80 sec in the graph v0.9.0 of the add-on was running, from about -65 sec the v0.10.0 was running. Downloading the same file.

Screenshot 2023-03-31 17 01 56

Running speed tests shows a similar picture.

@frenck
Copy link
Member

frenck commented Apr 15, 2023

The only difference between those versions, is the addition of Taildrop support.

I've added an option in #185 to provide the option to disable it. Once shipped, that might be a good one to test disabled.

../Frenck

@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label May 16, 2023
@GoetzGoerisch
Copy link
Author

Not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label May 17, 2023
@GoetzGoerisch
Copy link
Author

@frenck any ETA when #185 is in a release?

@frenck
Copy link
Member

frenck commented May 20, 2023

Nope, there is a blocking issue that needs to be resolved first.

@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jun 20, 2023
@GoetzGoerisch
Copy link
Author

Not stale, wating for blocking issue to be resolved to test.

@lmagyar
Copy link
Contributor

lmagyar commented Jun 20, 2023

@GoetzGoerisch Meanwhile you can test #185 in my fork at: https://github.com/lmagyar/homeassistant-addon-tailscale (this is a drop in replacement until the official add-on is released, it contains a workaround for the blocking issue)

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jun 21, 2023
@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jul 21, 2023
@GoetzGoerisch
Copy link
Author

Could not test. Not stale

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jul 22, 2023
@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Aug 21, 2023
@GoetzGoerisch
Copy link
Author

As per my recent tests with the forked extension, from @lmagyar, I see better results again.

Would prefer to leave it open until the upstream is merged.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Aug 22, 2023
@gabiginorio
Copy link

gabiginorio commented Aug 27, 2023

As per my recent tests with the forked extension, from @lmagyar, I see better results again.

Would prefer to leave it open until the upstream is merged.

Question here, did you just test with the forked extension default settings or did you set the option to "disable" the taildrop feature?

@gabiginorio
Copy link

Hi @GoetzGoerisch just following up to see if you had an answer to my above question.

Also, anyone know if there's a latest estimate for when the new release is coming out with these features?

@GoetzGoerisch
Copy link
Author

@gabiginorio sorry for the delay. Left the default which is Taildrop OFF.

Tested with and without today. Taildrop still reduces throughout, but not as much as the 0.10.0 version.

@lmagyar
Copy link
Contributor

lmagyar commented Sep 24, 2023

Left the default which is Taildrop OFF.

Just a note: by default taildrop is enabled! If there is no explicit taildrop: false line in the config, taildrop is enabled!

# Disable taildrop service when it is has been explicitly disabled
if bashio::config.false 'taildrop'; then
    rm /etc/s6-overlay/s6-rc.d/user/contents.d/taildrop
fi

@GoetzGoerisch
Copy link
Author

Thanks @lmagyar! I tried it with explicitly swtiching Taildrop on and off.

Taildrop on shows less throughput but still better with the 0.10.0 default add-on.

@github-actions
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Oct 25, 2023
@GoetzGoerisch
Copy link
Author

Needs to be revised with the latest release.

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Oct 26, 2023
@frenck frenck mentioned this issue Oct 27, 2023
Copy link

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Nov 26, 2023
@GoetzGoerisch
Copy link
Author

Resolved with v0.13.1

@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale There has not been activity on this issue or PR for quite some time.
Projects
None yet
Development

No branches or pull requests

4 participants