Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-nodejs base image #384

Merged
merged 3 commits into from Feb 9, 2024
Merged

Use non-nodejs base image #384

merged 3 commits into from Feb 9, 2024

Conversation

inverse
Copy link
Contributor

@inverse inverse commented Feb 5, 2024

Proposed Changes

Use builder image to perform asset build and copy into image that will run the application.

Will require modification if #381 is merged first or vice versa.

Related Issues

(Github link to related issues or pull requests)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @inverse 👍

../Frenck

@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Feb 9, 2024
@frenck frenck merged commit 85100fc into hassio-addons:main Feb 9, 2024
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants