Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:ambulances: Fixes path handling in certificates #6

Merged
merged 1 commit into from May 21, 2019

Conversation

frenck
Copy link
Member

@frenck frenck commented May 20, 2019

Proposed Changes

If an SSL cert is in a subfolder, it will fail.
The regex used for replacement is using slashes, slashes break paths.

Related Issues

n/a

Copy link
Member

@timmo001 timmo001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@timmo001 timmo001 merged commit 86d80af into master May 21, 2019
@timmo001 timmo001 deleted the fixes-cert-in-subfolder branch May 21, 2019 11:17
@addons-assistant
Copy link

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@addons-assistant addons-assistant bot locked as resolved and limited conversation to collaborators Jun 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants