Do not raise undefined method base fixes #59

Gemfile

@@ -1,4 +1,4 @@
-source :rubygems
+source 'https://rubygems.org'
 
 gemspec
 

Gemfile.lock

@@ -5,7 +5,7 @@ PATH
       rack (>= 1.0)
 
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
     diff-lcs (1.1.3)
     rack (1.3.0)

lib/warden/strategies.rb

@@ -11,7 +11,8 @@ def add(label, strategy = nil, &block)
           raise NoMethodError, "authenticate! is not declared in the #{label.inspect} strategy"
         end
 
-        unless strategy.ancestors.include?(Warden::Strategies::Base)
+        base = Warden::Strategies::Base
+        unless strategy.ancestors.include?(base)
           raise "#{label.inspect} is not a #{base}"
         end
 

spec/warden/proxy_spec.rb

@@ -2,7 +2,6 @@
 require 'spec_helper'
 
 describe Warden::Proxy do
-
   before(:all) do
     load_strategies
   end
@@ -340,7 +339,6 @@
       end
       setup_rack(app).call(@env)
     end
-
   end
 
   describe "set user" do
@@ -512,7 +510,6 @@
   end
 
   describe "logout" do
-
     before(:each) do
       @env['rack.session'] = {"warden.user.default.key" => "default key", "warden.user.foo.key" => "foo key", :foo => "bar"}
       @app = lambda do |e|
@@ -665,7 +662,7 @@
         app = lambda do |e|
           e['warden'].should be_authenticated
         end
-        result = setup_rack(app).call(@env)
+        setup_rack(app).call(@env)
       end
 
       it "should yield to a block when the block is passed and authenticated" do
@@ -700,7 +697,7 @@
         app = lambda do |e|
           e['warden'].should_not be_authenticated
         end
-        result = setup_rack(app).call(@env)
+        setup_rack(app).call(@env)
       end
 
       it "should return false if scope cannot be retrieved from session" do
@@ -786,7 +783,7 @@
         app = lambda do |e|
           e['warden'].should be_unauthenticated
         end
-        result = setup_rack(app).call(@env)
+        setup_rack(app).call(@env)
       end
 
       it "should yield to a block when the block is passed and authenticated" do
@@ -828,6 +825,8 @@ def def_app(&blk)
 
 describe "dynamic default_strategies" do
   before(:all) do
+    load_strategies
+
     class ::DynamicDefaultStrategies
       def initialize(app, &blk)
         @app, @blk = app, blk

spec/warden/strategies_spec.rb

@@ -11,13 +11,23 @@ def authenticate!
     Warden::Strategies[:strategy1].ancestors.should include(Warden::Strategies::Base)
   end
 
-  it "should raise an error if I add a strategy via a block, that does not have an autheniticate! method" do
+  it "should raise an error if I add a strategy via a block, that does not have an authenticate! method" do
     lambda do
       Warden::Strategies.add(:strategy2) do
       end
     end.should raise_error
   end
 
+  it "should raise an error if I add a strategy that does not extend Warden::Strategies::Base" do
+    non_base = Class.new do
+      def authenticate!
+      end
+    end
+    expect do
+      Warden::Strategies.add(:strategy_non_base, non_base)
+    end.to raise_error(/is not a Warden::Strategies::Base/)
+  end
+
   it "should allow me to get access to a particular strategy" do
     Warden::Strategies.add(:strategy3) do
       def authenticate!; end